Refactoring and new generator to aid in responses.

WhiteHouse / petitions

Drupal installation profile powering We The People at petitions.whitehouse.gov

https://petitions.whitehouse.gov/

1.14k stars 336 forks source link

Refactoring and new generator to aid in responses. #14

Open dellis23 opened 12 years ago

dellis23 commented 12 years ago

I've made the code base much cleaner while allowing future responses to be issued in an automated manner. We just need to add a few more generic adjectives and adverbs and this new functionality will truly shine!

WDC commented 12 years ago

I'm not sure removing 37,958 lines of code - albeit some of them just comments - is the right way to handle things. You might consider staging this commit, because you do have some good changes. However, not all of them are good.

dannygreg commented 12 years ago

This is a huge diff to come in one commit. Try breaking it up into smaller commits, it would make it much easier to review and cherry pick changes.

Bastlynn commented 12 years ago

This is not a commit made with any honest intent to improve the existing work. Political irony noted, but let's close this pull request and get on with working to improve the codebase for use by other groups and organizations.