WhiteMagic / JoystickGremlin

A tool for configuring and managing joystick devices.
http://whitemagic.github.io/JoystickGremlin/
GNU General Public License v3.0
324 stars 46 forks source link

'Unexpected type float' after building from source. #386

Open henniss opened 2 years ago

henniss commented 2 years ago

I'm encountering an odd error after building this project (from develop, and also from Release_13.3). The project runs, but I get exceptions when I open various UI elements (e.g. the input viewer, or the response curve):

jg-geometry-bug

input-viewer

This is odd, because I've never encountered this when running the version of 13.3 available on the download page. It also looks to be the expected behavior: PyQt docs don't seem to indicate that these methods ever excepted float values.

Perhaps I have the wrong version of PyQt5? Or is there some magic I've forgotten to invoke when building?

$ python -V
Python 3.10.0
$ pip list
Package                   Version
------------------------- --------
altgraph                  0.17.2
future                    0.18.2
pefile                    2021.9.3
Pillow                    8.4.0
pip                       21.3.1
pyinstaller               4.7
pyinstaller-hooks-contrib 2021.3
pypiwin32                 223
PyQt5                     5.15.6
PyQt5-Qt5                 5.15.2
PyQt5-sip                 12.9.0
PyQt5-stubs               5.15.2.0
pywin32                   302
pywin32-ctypes            0.2.0
reportlab                 3.6.2
setuptools                57.0.0
wheel                     0.36.2
WhiteMagic commented 2 years ago

I suspect that there might have been some tightening up of type conversion from Python to Qt5 in one of the updates. Qt5 has two different types for points, QPoint and QPointF. Another part of the same code uses QPointF and I would assume replacing the offending line with QPointF would solve the problem as the drawImage has overloads for both QPoint and QPointF.