search

Whiteknight / Rosella

A collection of tools and building blocks for Parrot
http://whiteknight.github.com/Rosella
Artistic License 2.0
14 stars 3 forks source link

Tests fail. #43

Open sa1 opened 11 years ago

sa1 commented 11 years ago

Test results here

sa1 commented 11 years ago

OS: archlinux, parrot version: 5.3(from archlinux repos), rosella version was this sha1: 46daeca8a9016b770228e05d434e88b99208889f . EDIT: It doesn't seem to be the latest Rosella, but this was the version checked out by git submodule update in parrot-libgit2. Edited title accordingly.

sa1 commented 11 years ago

On latest master(3d7999ae0bd64a6fe0616aa707f69f21b708fa97), this is the result.

leto commented 11 years ago

Thanks for the bug report! You may be the first person to run these tests on Arch. Can you get any more detailed test output?

Yes, parrot-libgit2 is pegged against an old version, because sometimes the Rosella API changes.

sa1 commented 11 years ago

For 46daeca8a9016b770228e05d434e88b99208889f, parrot t/path/Path.t shows:

error:imcc:syntax error, unexpected IDENTIFIER ('INIT')
    in file 't/path/Path.t' line 1

current instr.: '__default_get_packfile' pc 408 (frontend/parrot2/prt0.pir:151)

and parrot t/template/TemplateEval.t shows:

error:imcc:syntax error, unexpected IDENTIFIER ('function')
    in file 't/template/TemplateEval.t' line 1

current instr.: '__default_get_packfile' pc 408 (frontend/parrot2/prt0.pir:151)

For 3d7999ae0bd64a6fe0616aa707f69f21b708fa97, parrot t/winxed_test/Vector.t shows:

error:imcc:'$load' is not a valid register name
     in file 't/winxed_test/Vector.t' line 1
leto commented 11 years ago

All these errors are from using parrot instead of the "winxed" binary to run the tests.

sa1 commented 11 years ago

For 46daeca8a9016b770228e05d434e88b99208889f, TemplateEval.t https://gist.github.com/sa1/5463177

For Path.t, I just get t/path/Path.t:1: Unexpected token near INIT

For 3d7999ae0bd64a6fe0616aa707f69f21b708fa97 Nested.t https://gist.github.com/sa1/5463200

leto commented 11 years ago

just for reference, parrot-libgit2 only works with the version that is specified in the rosella submodule. Any other version is not guaranteed to work and probably won't.

On Wed, Apr 24, 2013 at 11:14 PM, Saurabh Kumar notifications@github.comwrote:

OS: archlinux, parrot version: 5.3(from archlinux repos), rosella version was master branch.

— Reply to this email directly or view it on GitHubhttps://github.com/Whiteknight/Rosella/issues/43#issuecomment-16990351 .

Jonathan "Duke" Leto jonathan@leto.net Leto Labs LLC http://letolabs.com 209.691.DUKE http://duke.leto.net @dukeleto https://twitter.com/dukeleto

sa1 commented 11 years ago

Yeah, I'm testing the master version in another location actually just to document it for the bug report.

leto commented 11 years ago 
invoke() not implemented in class 'PackfileView'

That is probably a genuine bug. I think PackfieViews changed recently. More research needed...

leto commented 11 years ago

Null PMC access in find_method('subtest')

that seems like a genuine Rosella bug too. Any ideas, @Whiteknight ?

Benabik commented 11 years ago

On Parrot and Rosella master, I get no test failures. :-/

Benabik commented 11 years ago

Path.t is an NQP script and should be run via parrot-nqp t/path/Path.t. I'm assuming you tried to run it with winxed or parrot instead.

The Nested.t results look like the tests are not getting called via Rosella.Test.test, so the status attribute isn't getting initialized properly. Or perhaps you're using an old version of Rosella.Test somehow.

I don't know what's causing the TemplateEval.t failures, but AFAICT (the line numbers don't line up for me, so I'm having to guess here) it looks like Rosella.Template.Node.Eval.compile_func is returning the raw return value of compilation, when it's supposed to be looking for a specific function.

All of this seems to add up to the tests not matching the version of Rosella being used. Perhaps you installed the version from the libgit2 submodule and are running the tests from master?

sa1 commented 11 years ago

@Benabik Indeed I was running parrot instead of parrot-nqp for Path.t.

The version of rosella installed was that from the submodule, and the tests were run in the same submodule. The TemplateEval.t results remain the same.

Now that you point it out, this was indeed a problem with my testing procedure for master (Nested.t failures). The installed libraries were old. Installing the correct version fixes those.

@leto Should we update the version of Rosella used? I am not sure how much API changed.

leto commented 11 years ago

@sa1 don't update the version of Rosella unless absolutely necessary