Whiteknight / mediawiki-embedvideo

Flash video embedding extension for MediaWiki
http://whiteknight.github.com
Other
23 stars 54 forks source link

EmbedVideo creates an extra leading paragrah break #23

Open eccentricon opened 12 years ago

eccentricon commented 12 years ago

Here's the wikitext use-case. Compare the space between the three paragraphs.

There's an embedded video in the third paragraph of this sample text.

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam a lorem elit, sit amet aliquet mi. Phasellus ornare leo ac enim commodo placerat. Proin sollicitudin risus ac est viverra accumsan. Nunc vulputate lorem in velit ultrices sit amet feugiat est tincidunt. Nam adipiscing ultrices gravida. Fusce ac orci mauris. Donec cursus lobortis purus, id accumsan nunc ullamcorper mollis. Nunc vestibulum nisl quis leo cursus eget ornare arcu ultricies. Aliquam varius hendrerit odio, vel facilisis quam elementum vitae. Mauris id laoreet quam. Morbi in nisi in ipsum pharetra volutpat. In quis magna sed sem sodales ullamcorper at nec quam.

{{#ev:youtube|46iljx1cw04|180|right|Vistaprint [[Creative Services]] on YouTube}}Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam a lorem elit, sit amet aliquet mi. Phasellus ornare leo ac enim commodo placerat. Proin sollicitudin risus ac est viverra accumsan. Nunc vulputate lorem in velit ultrices sit amet feugiat est tincidunt. Nam adipiscing ultrices gravida. Fusce ac orci mauris. Donec cursus lobortis purus, id accumsan nunc ullamcorper mollis. Nunc vestibulum nisl quis leo cursus eget ornare arcu ultricies. Aliquam varius hendrerit odio, vel facilisis quam elementum vitae. Mauris id laoreet quam. Morbi in nisi in ipsum pharetra volutpat. In quis magna sed sem sodales ullamcorper at nec quam.
eccentricon commented 12 years ago

A workaround is to wrap the #ev call in a div style="float:right;" element.

Whiteknight commented 12 years ago

Thanks for the report. I'll have to play around with a fix. It probably won't happen before the holiday (unless somebody comes up with a pull request between now and then).