search

Whiteknight / mediawiki-embedvideo

Flash video embedding extension for MediaWiki
http://whiteknight.github.com
Other
23 stars 52 forks source link

Http/Https Independent Requests #35

Open BigDub opened 10 years ago

BigDub commented 10 years ago

Removed "http:" from service urls. This allows the requests to match whatever protocol the page was loaded in. If the user was in https the video requests will be https. If the user was in http, the requests will be http. Admittedly, I only tested 'youtube' because that is what I needed. It should work for the others but, again, I've not tested it.

TomMettam commented 10 years ago

Most of these services don't support https, so you'll break support on the older browsers. It needs to be done on a service-by-service basis, i think.

ttguy commented 10 years ago

I just want to vote that this fix should be improved and implemented - make it youtube specific and deploy it. There are situations where the EmbedVideo extension fails because of secure wiki pages and insecure youtube calls. Recently userbase.kde.org changed the wiki to make SSL manditory accross the site. And this broke youtube embeds in modern browsers because the page was delivering mixed content and the browser blocked the insecure YT content - leaving a blank space on the page. So you should allow prasad83s fix or something like it to fix this issue. userbase.kde.org hacked a fix into EmbedVideo.Services.php to get around this issue but it should work out of the box.