Whitesands13 / Whitesands

The Whitesands Space Station 13 Codebase.
https://whitesands13.github.io/Whitesands/
GNU Affero General Public License v3.0
18 stars 65 forks source link

[BUG] Changing an Account's Salary Sets it to Null #836

Closed untrius closed 3 years ago

untrius commented 3 years ago

Attempting to change an account's salary in the Departmental Finances Manager sets the new salary to null.

image

Round ID: Several

Reproduction:

1) Open the NT Software Hub on a console and download Bank Account Manager and Departmental Finances Manager Optional 1) Use Bank account Manager to create new accounts to test with Optional 2) Get some blank ids, give the cards names at the id console, alt click each card to link the account number 2) Open Departmental Finances Manager 3) Make sure you have the correct access to change salaries (Captain-level access lets you ignore this) 4) Attempt to change someone's salary (just clicking the box and clicking away is enough) 5) Salary will say "null" 6) Use Bank Account Manager or Departmental Finances Manager to watch that the null salary will not increase while others do