search

WhitestormJS / whitestorm-app-boilerplate

[WIP] WhitestormJS 2 App boilerplate
http://whs-boilerplate-app.surge.sh/
MIT License
45 stars 17 forks source link

Warning: ExtrudeBufferGeometry was not found #11

Closed hirako2000 closed 7 years ago

hirako2000 commented 7 years ago

no impact, but the console shows this warning: ./~/whs/src/components/meshes/Extrude.js 50:59-80 export 'ExtrudeBufferGeometry' was not found in 'three'

sasha240100 commented 7 years ago

@hirako2000 This line should be rewritten.

hirako2000 commented 7 years ago

ok, I will fix this.

hirako2000 commented 7 years ago

looks right?

  buildGeometry(params = {}) {
    const extrudeGeometry = new ExtrudeGeometry(
      params.geometry.shapes,
      params.geometry.options
    );

    return params.buffer && !params.softbody ? new BufferGeometry().fromGeometry(extrudeGeometry) : extrudeGeometry;
  }
sasha240100 commented 7 years ago

@hirako2000 yes! good.

sasha240100 commented 7 years ago

Issue moved to https://github.com/WhitestormJS/whitestorm.js/issues/237