Open sasha240100 opened 7 years ago
/ping @thejmazz
One suggestion for the module API: swap this
and self
in integrate(self)
. Currently:
class Module {
integrate(self) {
// `this` is the app instance
// `self` is the module instance
}
}
let app = new WHS.App([new Module()]);
A new API would look like:
class Module {
version = 2; // Tell WHS to use a new module API. This way existing modules don't break.
integrate(component) {
// `this` is the module instance
// `component` is the app instance
}
}
API
This issue exists for v2.x.x API discussion. Please, add your API suggestions in comments below
App
components
modules
Version:
Issue type:
Tested on:
###### Desktop - [ ] Chrome - [ ] Chrome Canary - [ ] Chrome dev-channel - [ ] Firefox - [ ] Opera - [ ] Microsoft IE - [ ] Microsoft Edge ###### Android - [ ] Chrome - [ ] Firefox - [ ] Opera ###### IOS - [ ] Chrome - [ ] Firefox - [ ] Opera