WhitewaterFoundry / Fedora-Remix-for-WSL

Fedora Remix for Windows Subsystem for Linux.
Other
718 stars 51 forks source link

Document `fedoraremix` GUID #94

Open xobs opened 3 years ago

xobs commented 3 years ago

Is your feature request related to a problem? Please describe. Windows Terminal requires the GUID in order to know which program to launch. Fedora Remix doesn't appear to have its GUID documented anywhere, and it can't be discovered with tne normal methods.

The documentation should list the GUID.

Describe the solution you'd like List the GUID {d3f31bee-5823-5ed8-8e04-f31ed54f2cd9}

Describe alternatives you've considered Another possibility is to list the entry in settings.json:

            {
                "guid": "{d3f31bee-5823-5ed8-8e04-f31ed54f2cd9}",
                "hidden": false,
                "name": "Fedora Remix",
                "source": "Windows.Terminal.Wsl"
            },
crramirez commented 3 years ago

Well until now I tough that Windows Terminal generates these numbers and is different by machine. But this GUID is the same as I have. This GUID is indeed different from the one which identifies the distribution in the Windows registry. So looks like it is Windows Terminal specific.

Why it is important to have it documented if Windows Terminal fills the settings.json automatically?

xobs commented 3 years ago

Perhaps you're correct, and it's not important to document it. I installed Fedora Remix on another machine, and discovered that Windows Terminal does indeed discover the new distro when it is restarted. Since most settings in Windows Terminal take effect immediately without restart, I didn't realize that it wouldn't pick up the new distro right away.

Documenting the GUID is only important if users want to be able to use Fedora Remix right away without restarting Windows Terminal. Otherwise, it's fine to omit it.

blinderjay commented 3 years ago

Well until now I tough that Windows Terminal generates these numbers and is different by machine. But this GUID is the same as I have. This GUID is indeed different from the one which identifies the distribution in the Windows registry. So looks like it is Windows Terminal specific.

Why it is important to have it documented if Windows Terminal fills the settings.json automatically?

My terminal do not have any entry for fedora remix, so I want to create one, Is there any way to seek the GUID number?

crramirez commented 3 years ago

Hello,

This is the id: d3f31bee-5823-5ed8-8e04-f31ed54f2cd9

And you can grab it from here: https://github.com/WhitewaterFoundry/Fedora-Remix-for-WSL/blob/master/Fedora-Remix-for-WSL/Public/Fragments/fedoraremix.json

But Windows Terminal should create it automatically. Have you closed and opened it again?

Regards, Carlos