Closed m13253 closed 3 years ago
Thank you for your contribution. It is very well made. We will make some test to include it in the next images.
I have been experimenting with bass and it does the job pretty well. The problem here is that the user must have it installed
Regards,
Excellent work! thank you. It will be included in the next release of Fedora Remix. It is now included in upgrade.sh
After the recent fish upgrade, fish upstream decided to deprecate command ^stderr_redirect
in favor of command 2>stderr_redirect
. Therefore, I need to update the script to change all ^
into 2>
.
I planned to submit a new pull request, but I don't know where the file is moved.
Please allow me to upload the modified script as an attachment below. If you are satisfied, please merge it manually.
Attachment: /etc/fish/conf.d/00-remix.fish
Hello @m13253,
Thank you for your support. The file was moved here: https://github.com/WhitewaterFoundry/fedora-remix-rootfs-build/blob/master/linux_files/00-remix.fish
Regards, Carlos
I merged the change thanks for the contribution, it solves also: https://github.com/WhitewaterFoundry/Fedora-Remix-for-WSL/issues/128
Fish shell is known for its incompatibility by design with POSIX shells. Therefore, 00-remix.sh does not run on fish shell.
It might be controversial to do this port because most fish users are able to figure out a workaround themselves without relying on the upstream, but the logic in this script is so complicated that I believe it is better to provide such a port.
(P.S.: I only tested the 00-remix.fish script itself, although I also modified the packaging scripts. If possible, please help me make sure the packaging works before merging.)
(Update: I am not sure why the CI check failed. According to the error messages, it seems that the problem is not related to this PR.)