This PR resolves issue #771, which is ultimately the result of multiple independent issues related to building.
Because there are a couple different ways to resolve the issues I encountered, there's room for discussion on exactly how fixes should be implemented upstream. I'll try to reference specific issues and pertinent details in this PR and then update BUILDING.md in a subsequent commit to document/reflect the agreed on changes to what the build process should look like.
First and foremost are the changes proposed in https://github.com/WhitewaterFoundry/legacy-rootfs-build-scripts/pull/1 -- getting pengwin-base built successfully first is critical. Some changes were needed so the script would continue to work as intended. As proposed, it is intended to work with the linux_files/setup file already in this repository instead of the one in the legacy-rootfs-build-scripts. Alternatively, perhaps one of the non-legacy scripts in https://github.com/WhitewaterFoundry/pengwin-rootfs-builds can referenced in build docs and used instead.
The next major issue is dependencies and the VS build environment. Current documentation recommends VS 2019, but platform tools v143 is not compatible/available on VS 2019. See the changes to .vcxproj files.
Past that, I encountered extensive NuGet dependency issues that were ultimately resolved by the changes made to build.bat to automatically restore dependencies. Other issues that were resolved without changes to specific scripts were where to modify the package thumbprint and exact steps related to trusting the signing certificate before the msixbundle is allowed to be installed.
This PR resolves issue #771, which is ultimately the result of multiple independent issues related to building.
Because there are a couple different ways to resolve the issues I encountered, there's room for discussion on exactly how fixes should be implemented upstream. I'll try to reference specific issues and pertinent details in this PR and then update BUILDING.md in a subsequent commit to document/reflect the agreed on changes to what the build process should look like.
First and foremost are the changes proposed in https://github.com/WhitewaterFoundry/legacy-rootfs-build-scripts/pull/1 -- getting pengwin-base built successfully first is critical. Some changes were needed so the script would continue to work as intended. As proposed, it is intended to work with the linux_files/setup file already in this repository instead of the one in the legacy-rootfs-build-scripts. Alternatively, perhaps one of the non-legacy scripts in https://github.com/WhitewaterFoundry/pengwin-rootfs-builds can referenced in build docs and used instead.
The next major issue is dependencies and the VS build environment. Current documentation recommends VS 2019, but platform tools v143 is not compatible/available on VS 2019. See the changes to .vcxproj files.
Past that, I encountered extensive NuGet dependency issues that were ultimately resolved by the changes made to build.bat to automatically restore dependencies. Other issues that were resolved without changes to specific scripts were where to modify the package thumbprint and exact steps related to trusting the signing certificate before the msixbundle is allowed to be installed.