Feature/remove tmp file dependency

WhitewidowScanner / whitewidow

SQL Vulnerability Scanner

972 stars 235 forks source link

Closed TylerRockwell closed 7 years ago

TylerRockwell commented 7 years ago

If a file doesn't exist, it should just get created instead of causing an error.

Created FileHelper class with open_or_create method that will create a file and all directories leading to it if they don't exist
This helper can be used anywhere a filename is normally used to add automatic file creation
Changed declared constants (in the tmp and log directories) to use this new method.
Added tests for FileHelper class
Improved flexibility of Scanner test

Ekultek commented 7 years ago

What version did you pull from?

TylerRockwell commented 7 years ago

This branch was rebased on the most recent master

Ekultek commented 7 years ago

run a version check on it and let me know what it says, I was just about to push some fixes to it

Ekultek commented 7 years ago

How about this, let me push a couple things, re-implement it to the newest push and I'll approve it, gonna close this one out, cool?

TylerRockwell commented 7 years ago

You can leave the PR open. Just push up your changes, and I'll rebase on them. The PR will update on its own.

TylerRockwell commented 7 years ago

1.9.4.6 is the version I was working with.

Ekultek commented 7 years ago

Sounds good, shouldn't be to hard, there wasn't very many changes, just some minor things.