Refactor/scanner

[TylerRockwell]

Why?

Large methods are hard to read/follow/debug/change

What Changed?

• Simplified some methods in settings.rb
• Refactored format_file in scanner.rb
• Removed Copy module in favor of Ruby's FileUtil.copy method
• Added pry-byebug for easier step-by-step debugging

[Ekultek]

What is the purpose of adding pry to this?

[TylerRockwell]

Pry is there for ease of debugging. We don't have to keep it in the Gemfile if you don't want, but I thought it may be easier than adding it whenever we need to step through the code.

[Ekultek]

Okay, just thought you might have some auto debugging tactic that I didn't know about, will this still remove blank lines from files and all white space? For example:

Turn this:

http://example.example.com/php?id=is

        http://example.example.com/php?id=i

  http://example.example.com/php?id=it

Into this:

http://example.example.com/php?id=is
http://example.example.com/php?id=i
http://example.example.com/php?id=it

[TylerRockwell]

Hmm...looks like it's not at the moment. Hold off on merging this, and I'll figure out what's going on.

Blank lines are still getting removed, but leading whitespace is still there.

[Ekultek]

Take your time man

[TylerRockwell]

It's fixed. I was just missing .strip in this block

{ |outfile| outfile.puts(line.strip) unless line.chomp.empty? }

[TylerRockwell]

I'll add a test for that in the near future.

[Ekultek]

Drop pry and I'll test it tomorrow morning

[Ekultek]

You know what actually I have an idea for pry so keep it there and I'll test it tomorrow

[Ekultek]

It won't find the files

 __      __.__    .__  __         __      __.__    .___
/  \    /  \  |__ |__|/  |_  ____/  \    /  \__| __| _/______  _  __
\   \/\/   /  |  \|  \   __\/ __ \   \/\/   /  |/ __ |/  _ \ \/ \/ /
 \        /|   Y  \  ||  | \  ___/\        /|  / /_/ (  <_> )     /
  \__/\  / |___|  /__||__|  \___  >\__/\  / |______ | \____/ \/\_/
       \/       \/              \/      \/           \/    v1.9.5.8(dev)

Clone: https://github.com/WhitewidowScanner/whitewidow.git
Downloads: https://github.com/WhitewidowScanner/whitewidow/releases
[ ! ] Use of this program for malicious intent is illegal. For more information
run the --legal flag

[08:37:37 INFO] Formatting file

Hey now my friend, I know you're eager, I am also, but that file tmp/sites.txt
either doesn't exist, or it's not in the directory you say it's in..

I'm gonna need you to go find that file, move it to the correct directory and th
en
run me again.

Don't worry I'll wait!

[Ekultek]

hahahaha nvm...

[Ekultek]

alright so drop pry from the gem file and i'll merge it