search

WhoCraft / TardisRefined

A Minecraft mod for Forge and Fabric which brings the TARDIS from Doctor Who to Minecraft.
Other
58 stars 23 forks source link

Tardis forgets last known position on server closing and rejoin, if in the Tardis closing the server (Forge) #160

Closed Bonkjumper closed 1 year ago

Bonkjumper commented 1 year ago

Issue description

So, I was making a trip back home in my Tardis, when I felt it was a good time to turn off for the day, so I leave, skip a few days later I come back to my world, I spawn in my tardis with no issue, but I notice I couldn't leave my tardis, thinking it's perhaps I didn't land in a dimension that hasn't loaded yet I check the computer bank to see where I am, however I couldn't use it, all the other controls worked but the computer bank, so I decide I'll just demat back to where I normally land my tardis, I try to demat and the server crashes, The immediate crash log tells me the exact problem, but there's probably more to it, which is why I am reporting it here. My world is probably bricked and I am kinda an idiot for not backing it up, but eh, this gives me a chance to do a good restructure of my self modpack.

Steps to reproduce

  1. Enter a Tardis
  2. Remain in a Tardis 3.Close the server/world while maintaining step 2
  3. renter the server
  4. attempt any form of dematerialization
  5. Server dies and any form of escaping the Tardis fails

Minecraft version

1.19.4 (Latest)

Mod Loader Platform type

Forge

Mod Loader version

Forge Version 43.2.14

Tardis Refined version

v1.0

Other relevant versions

No response

Attach the relevant crash report file or log file: (Don't know how to find a crash report file? See the Minecraft Wiki Tutorial

https://pastebin.com/t1CA8Ny2

Bonkjumper commented 1 year ago

The mod list is in the crash-log if you need it, but if you need any more details, I am more then happy to share

AlienXtream commented 1 year ago

thats not the whole crash report (actually missing the crash itself). if its what i assume i do believe this is a known issue. though your world shouldn't be bricked. this happens with modded dimensions. not sure on the details but the crash is mroe of a failsafe when the dimension is "null". the tardis position will be reset to 0, 0, 0 in the overworld next time you join back. again, thats assuming its the dimension bug. something something blame forge/vanilla dimensions stuff iirc. not an expert on this stuff.

Bonkjumper commented 1 year ago

Oh shoot, did I forget to copy that in?, ok I’ll later update it

AlienXtream commented 1 year ago

i assume its basically the same as the crash report in this one? https://github.com/CommandrMoose/TardisRefined/issues/154

Bonkjumper commented 1 year ago

It was similar, but it was already landed, so perhaps it is the same issue, but can be triggered by other circumstances

Bonkjumper commented 1 year ago

There the Log was updated

tEMMIE6823 commented 1 year ago

Just incase if it helps I have the error right here

[12:27:69] [Server thread/ERROR]: Failed to handle packet net.minecraft.network.protocol.game.ServerboundInteractPacket@3733c96c, suppressing error java.lang.NullPointerException: Cannot invoke "whocraft.tardis_refined.common.tardis.TardisNavLocation.getPosition()" because "currentLocation" is null at TRANSFORMER/tardis_refined@1.0.1/whocraft.tardis_refined.common.network.messages.OpenMonitorMessage.(OpenMonitorMessage.java:34) at TRANSFORMER/tardis_refined@1.0.1/whocraft.tardis_refined.common.tardis.control.ship.MonitorControl.onRightClick(MonitorControl.java:26) at TRANSFORMER/tardis_refined@1.0.1/whocraft.tardis_refined.common.entity.ControlEntity.lambda$handleRightClick$2(ControlEntity.java:311) at java.base/java.util.Optional.ifPresent(Optional.java:178) at TRANSFORMER/tardis_refined@1.0.1/whocraft.tardis_refined.common.entity.ControlEntity.handleRightClick(ControlEntity.java:296) at TRANSFORMER/tardis_refined@1.0.1/whocraft.tardis_refined.common.entity.ControlEntity.m7111(ControlEntity.java:178) at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.network.ServerGamePacketListenerImpl$1.lambda$onInteraction$0(ServerGamePacketListenerImpl.java:1568) at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.network.ServerGamePacketListenerImpl$1.m143678(ServerGamePacketListenerImpl.java:1550) at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.network.ServerGamePacketListenerImpl$1.m142143(ServerGamePacketListenerImpl.java:1565) at TRANSFORMER/minecraft@1.19.2/net.minecraft.network.protocol.game.ServerboundInteractPacket$InteractionAtLocationAction.m142457(ServerboundInteractPacket.java:146) at TRANSFORMER/minecraft@1.19.2/net.minecraft.network.protocol.game.ServerboundInteractPacket.m179617(ServerboundInteractPacket.java:66) at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.network.ServerGamePacketListenerImpl.m6946(ServerGamePacketListenerImpl.java:1546) at TRANSFORMER/minecraft@1.19.2/net.minecraft.network.protocol.game.ServerboundInteractPacket.m5797(ServerboundInteractPacket.java:53) at TRANSFORMER/minecraft@1.19.2/net.minecraft.network.protocol.game.ServerboundInteractPacket.m5797(ServerboundInteractPacket.java:13) at TRANSFORMER/minecraft@1.19.2/net.minecraft.network.protocol.PacketUtils.m131356(PacketUtils.java:22) at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.TickTask.run(TickTask.java:18) at TRANSFORMER/minecraft@1.19.2/net.minecraft.util.thread.BlockableEventLoop.m6367(BlockableEventLoop.java:157) at TRANSFORMER/minecraft@1.19.2/net.minecraft.util.thread.ReentrantBlockableEventLoop.m6367(ReentrantBlockableEventLoop.java:23) at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m6367(MinecraftServer.java:763) at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m6367(MinecraftServer.java:157) at TRANSFORMER/minecraft@1.19.2/net.minecraft.util.thread.BlockableEventLoop.m7245(BlockableEventLoop.java:131) at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m129961(MinecraftServer.java:746) at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m7245(MinecraftServer.java:740) at TRANSFORMER/minecraft@1.19.2/net.minecraft.util.thread.BlockableEventLoop.m18699(BlockableEventLoop.java:116) at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m130012(MinecraftServer.java:725) at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m130011(MinecraftServer.java:658) at TRANSFORMER/minecraft@1.19.2/net.minecraft.server.MinecraftServer.m206580(MinecraftServer.java:244) at java.base/java.lang.Thread.run(Thread.java:833)

sadly ive lost almost 10 worlds due to this error all of them hardcore :/

Jeryn99 commented 1 year ago

Fixed