WhoCraft / TardisRefined

A Minecraft mod for Forge and Fabric which brings the TARDIS from Doctor Who to Minecraft.
Other
58 stars 23 forks source link

Changing interior to Toyota crashes server #200

Closed oldtrain1 closed 6 months ago

oldtrain1 commented 8 months ago

Issue description

My friend on our modded survival world grew a Tardis, terraformed and everything fine. I already made one with ease and changed the interior on my own, with the only bug being a Tardis exterior where the Coral was placed, but that's only a minor bug. The real problem started when my friend made his Tardis. He made it, went inside and changed the exterior to Phone Booth and the interior to Future Nostalgia. He didn't like it so he changed to Toyota, where he said "the tp portal blocks at the door were gone", so he logged out and back in to see if it would fix it. It did not and now the server is in an infinite loop of crashing on startup.

Steps to reproduce

  1. Create Tardis via normal means (grow coral, terraform)
  2. Go inside
  3. Change exterior to Phone Booth, interior to Future Nostalgia
  4. Go outside
  5. Go inside
  6. Change to Toyota
  7. Leave game
  8. Joining back makes the server crash completely

Minecraft version

1.19.2 (Latest)

Mod Loader Platform type

Forge

Mod Loader version

Forge Version 43.3.0

Tardis Refined version

v1.0

Other relevant versions

No response

Attach the relevant crash report file or log file: (Don't know how to find a crash report file? See the Minecraft Wiki Tutorial

https://pastebin.com/CvvV8j13

CommandrMoose commented 8 months ago

This seems to be an issue to do with FerriteCore ((Neo)Forge). can you confirm the issue does not occur when the mod isn't installed?

Jeryn99 commented 8 months ago

No, this is us - we didn’t check for whether a block has a state before trying to edit that state, it’s from your old generation code

Happens when the shell block is being told to regenerate but no shell block is present

may be fixed now

github-actions[bot] commented 6 months ago

This issue has not recieved activity in a while - is it still a issue?