search

WhoCraft / TardisRefined

A Minecraft mod for Forge and Fabric which brings the TARDIS from Doctor Who to Minecraft.
Other
48 stars 18 forks source link

TardisClientData is a Sin #247

Closed Jeryn99 closed 1 month ago

Jeryn99 commented 1 month ago

We are still releasing with TardisClientData and that sucks because it's a terrible solution for having a ServerLevels Capability on the client. This leads to a issue where we have become complacent and started adding logic to the TardisClientData class which invokes crashes on servers as we have SoundInstances and LocalPlayer references which is too much for a @Enviroment annotation to take

This PR is in a rough state due to writing it to getting a server going but it will be fixed before merge

Jeryn99 commented 1 month ago

TODO: Look into this when entering a brand new TARDIS

image

Duzos commented 1 month ago

how're you opening up a server? im pretty sure you can runServer in intellij

Jeryn99 commented 1 month ago

how're you opening up a server? im pretty sure you can runServer in intellij

Yes, for both forge and fabric - I know

It's for this morning when I was patching things before having to rush out so I couldn't run the tests myself and @CommandrMoose did the testing and I read the servers live log

The issue is that one of the custom events we have references the ModelSet class and nukes the server - but this is easily fixed