Downport: 1.20.1

[MianReplicate]

This PR aims to port the current master branch 1.20.2 version of TR to 1.20.1 in full working state for both Neo (hopefully) and Fabric.

Can I just say that I am suffering? This port forced me to look into what a codec was to fix one (and I am 99% sure it's not fixed!)

[Olivier1152005]

Is there an easy way to download the decompiled version of the mod that is on GitHub without having to manually go to each file, download it, and then manually rebuild every file and path? Is there anything in particular you are having trouble with? I like this mod and want to help get it ported to 1.20.1.

[CommandrMoose]

Is there an easy way to download the decompiled version of the mod that is on GitHub without having to manually go to each file, download it, and then manually rebuild every file and path? Is there anything in particular you are having trouble with? I like this mod and want to help get it ported to 1.20.1.

I recommend looking into how git works. This PR is close to coming to a close. https://docs.github.com/en/repositories/creating-and-managing-repositories/cloning-a-repository

[Jeryn99]

Is there an easy way to download the decompiled version of the mod that is on GitHub without having to manually go to each file, download it, and then manually rebuild every file and path? Is there anything in particular you are having trouble with? I like this mod and want to help get it ported to 1.20.1.

Hello. What you are viewing is code that is cutting edge. What I mean by that is that it is so newly published that if you were to cut the review and dev process out and ran off with these files, you would end up destroying your Minecraft saves. This is a pull request for developers for tracking the port downwards and if you do not know what you are doing, you should not interact as you are hindering the process. Think of it as walking into a car factory and asking to take the car in its current state (Engine, no brakes yet though) because you love it, just wouldn't go down well

[50ap5ud5]

PR source branch needs to be switched to a recently created branch called minecraft/1.20.1_port before being moved out of a draft state.

It is a copy of the porting work but rebased on top of the latest 20.2 changes. This means this PR would up to date with the latest 1.20.2 changes. Those reviewing the PR would only be seeing changes that were made during the port.

[Jeryn99]

This does sound like we need to make a whole new PR?

[50ap5ud5]

This does sound like we need to make a whole new PR?

Actually, I think you are right here.

I had made a new branch in case I significantly changed the commit history. It looks it wasn't the case, so if we want to continue using this PR, we just need to override the LoxiGoose:minecraft/1.20.1 branch with that of the LoxiGoose:minecraft/1.20.1_port branch.

[50ap5ud5]

Ok, I've updated LoxiGoose:minecraft/1.20.1 to be rebased on top of WhoCraft:minecraft/1.20 changes so that we don't need to make a new PR.

[Jeryn99]

we're really damn cooking

[Jeryn99]

This is amazing work. The refactors made in the registry classes need changes as they currently prevent the ability for add-on mods to add new entries to TARDIS Refined. It also appears to remove previous functionality, some of which can be addressed with some better documentation.

When getting 1.20.1 running, we ripped out all the registry stuff in favour of CustomRegistry from Regeneration/Weeping Angels as a temporary measure as the intention was to get the mod running and see what we would need to fix at runtime. CustomRegistry was always a temporary measure and I should have documented it as so. The intention post fixes was to have your registry refactor ported down

[Jeryn99]

Comments either need to be removed or please tell my why they should stay.

There's a few changes on 1.20.2's branch that should be cherry picked in, but then I'd say it is GTG

All commented code has now been removed from the mod where not needed