search

WhoCraft / TardisRefined

A Minecraft mod for Forge and Fabric which brings the TARDIS from Doctor Who to Minecraft.
Other
58 stars 23 forks source link

Game crashes upon attempting to land the TARDIS in a void dimension #309

Closed nanuwo closed 3 months ago

nanuwo commented 5 months ago

Issue description

When trying to finish flight and land in a dimension where there are no solid blocks in the column (in this case Ad Astra's "Orbit" dimension) the game crashes. This is probably because findValidLocationInColumn calls itself with an offset BlockPos but can't find one in such a dimension

Steps to reproduce

Try to land the TARDIS in a dimension with only void

Minecraft version

1.20.1

Mod Loader Platform type

Fabric

Mod Loader version

Fabric Loader 0.15.11

Tardis Refined version

v2.0.2

Other relevant versions

No response

Attach the relevant crash report file or log file: (Don't know how to find a crash report file? See the Minecraft Wiki Tutorial

https://gist.github.com/nanuwo/f695ef7b6c20c5b028d372072243e02d

Hot-M3ss commented 5 months ago

This also happens when going to the Aether, which has blocks. crash-2024-06-08_11.14.27-server.txt

50ap5ud5 commented 5 months ago

Thanks, this will be looked into in future versions

Hot-M3ss commented 5 months ago

This also happens when going to the Aether, which has blocks. crash-2024-06-08_11.14.27-server.txt

To clarify I am running forge.

github-actions[bot] commented 3 months ago

This issue has not recieved activity in a while - is it still a issue?