WhoCraft / TardisRefined

A Minecraft mod for Forge and Fabric which brings the TARDIS from Doctor Who to Minecraft.
Other
48 stars 18 forks source link

Tardis error when placing/trying to enter before shearing off the vines #318

Open Hot-M3ss opened 1 week ago

Hot-M3ss commented 1 week ago

Issue description

Placed tardis root shell: [18:58:33] [Server thread/ERROR] [wh.ta.TardisRefined/]: Error in saveAdditional: null Tardis ID (could this be an invalid block?) [74, 73, 621]

if you walk into the door with vines over it and the console is spammed with: [18:57:06] [Server thread/ERROR] [wh.ta.TardisRefined/]: Error in onAttemptEnter: null Tardis ID (could this be an invalid block?) [72, 73, 621]

If you shear it this displays: [19:00:21] [Server thread/INFO] [wh.ta.TardisRefined/]: Writing ["tardis_refined:8df8f839-31f1-4eb2-aac0-7eeee0ad78d3","tardis_refined:35424194-d246-4d2c-9248-b44987da5e04","tardis_refined:35a26f33-9288-471f-9a24-fcfbab1f61c6","tardis_refined:a712ef3a-9059-477a-a6a5-070b6910c013"] to: E:\Minecraft\MCSS\servers\Regen 8.\Main World\tardis_refined_tardis_info.json [19:00:21] [Worker-Main-22/INFO] [minecraft/LoggerChunkProgressListener]: Preparing spawn area: 0% [19:00:22] [Worker-Main-31/INFO] [minecraft/LoggerChunkProgressListener]: Preparing spawn area: 4% [19:00:22] [Worker-Main-28/INFO] [minecraft/LoggerChunkProgressListener]: Preparing spawn area: 21% [19:00:23] [Worker-Main-6/INFO] [minecraft/LoggerChunkProgressListener]: Preparing spawn area: 42% [19:00:23] [Worker-Main-22/INFO] [minecraft/LoggerChunkProgressListener]: Preparing spawn area: 61% [19:00:24] [Worker-Main-13/INFO] [minecraft/LoggerChunkProgressListener]: Preparing spawn area: 83% [19:00:24] [Worker-Main-5/ERROR] [minecraft/Util]: Detected setBlock in a far chunk [61, 3], pos: BlockPos{x=991, y=77, z=53}, status: minecraft:features <---- this error is spammed

Exit Tardis: [19:01:29] [Server thread/ERROR] [wh.ta.TardisRefined/]: Error in saveAdditional: null Tardis ID (could this be an invalid block?) [70, 73, 620]

Steps to reproduce

  1. Place the TARDIS root shell. Error spammed in console
  2. Walk into it unsheared Error spammed in console
  3. Shear the door Error spammed in console
  4. Exit the tardis error spammed in console.

Minecraft version

1.20.1

Mod Loader Platform type

Forge

Mod Loader version

47.2.32

Tardis Refined version

v2.0.3

Other relevant versions

No response

Attach the relevant crash report file or log file: (Don't know how to find a crash report file? See the Minecraft Wiki Tutorial

No response

50ap5ud5 commented 1 week ago

This is intended behaviour. It was a debugging tool to help server owners identify Tardises which could not Terraform correctly.

This error message was needed because in the 1.19.2 versions, there was a bug where we didn't always setup the correct data on the root shell.

A community member contributed a temporary solution via https://github.com/WhoCraft/TardisRefined/pull/158 which is that error message you see.

It seems that the "fix" triggers unintentionally at a point when the TARDIS hasn't terraformed.

As we have since fixed the data issue with terraformed Tardises, that error message should really be removed @Jeryn99 @CommandrMoose to prevent confusion.

Hot-M3ss commented 6 days ago

Thank you for the quick reply! Sorry if it was a duplicate.