WhoIsSethDaniel / lualine-lsp-progress.nvim

LSP progress lualine component
MIT License
62 stars 2 forks source link

Generate client messages on attach #4

Closed rorystephenson closed 1 year ago

rorystephenson commented 1 year ago

Thanks for plugin! This PR contains a minor improvement to make progress indicator show up sooner.


Previously the lsp status was shown once lsp progress callbacks began firing however for some language servers (e.g. dart) there is a multi-second delay between the language server starting and when it begins firing progress callbacks and in this time no lsp progress was being shown.

This commit makes the lsp status display as soon as the language server attaches.

WhoIsSethDaniel commented 1 year ago

Thank you. Apologies for taking so long. I completely missed this PR when it was submitted.

petobens commented 1 year ago

@rorystephenson @WhoIsSethDaniel after this change I'm always seeing the In Progress/commenced message. I want lualine only to display when the lsp is loading. I tried removing the commenced bit from the following config but without success:

            {
                'lsp_progress',
                component_separator = { left = '', right = '' },
                message = {
                    initializing = 'Start…',
                    commenced = '*',
                    completed = 'Done!',
                },
                display_components = {
                    'lsp_client_name',
                    { 'message' },
                },

Any pointers are greatly appreciated.

Also is there a way to disable showing null-ls? Thanks in advance for the help!

WhoIsSethDaniel commented 1 year ago

Hi @petobens would you mind creating an issue (or discussion) for these things? I almost forgot about this question because the PR is closed and it doesn't show up (by default) on the dashboard. Thanks.

petobens commented 1 year ago

Sure. Done in https://github.com/WhoIsSethDaniel/lualine-lsp-progress.nvim/issues/6