WhoopInc / vagrant-s3auth

Vagrant plugin for private, versioned boxes on Amazon S3.
MIT License
108 stars 23 forks source link

Strip newlines from AWS credentials #4

Closed semifocused closed 9 years ago

semifocused commented 9 years ago

Simple tweak on the example for picking up credentials from within the Vagrantfile:

creds = File.read(File.expand_path('../.s3credentials')).lines
ENV['AWS_ACCESS_KEY_ID']     = creds[0].strip
ENV['AWS_SECRET_ACCESS_KEY'] = creds[1].strip

Without the .strip, I was getting newlines on the resulting AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY, thus causing authentication to fail.

waisbrot commented 9 years ago

Do you want to make this a pull request and I'll merge it?

semifocused commented 9 years ago

Sure, will do.

Best,

Mick Bass M +1.303.667.1227

From: Nathaniel Waisbrot notifications@github.com Reply-To: WhoopInc/vagrant-s3auth <reply@reply.git hub.com> Date: Saturday, November 1, 2014 at 6:10 PM To: WhoopInc/vagrant-s3auth vagrant-s3auth@noreply.github.com Cc: Mick Bass mick@mickbass.com Subject: Re: [vagrant-s3auth] Strip newlines from AWS credentials (#4)

Do you want to make this a pull request and I'll merge it?

‹ Reply to this email directly or view it on GitHub https://github.com/WhoopInc/vagrant-s3auth/issues/4#issuecomment-61388779 . {"@context":"http://schema.org","@type":"EmailMessage","description":"View this Issue on GitHub","action":{"@type":"ViewAction","url":"https://github.com/WhoopInc/va grant-s3auth/issues/4#issuecomment-61388779","name":"View Issue"}}

semifocused commented 9 years ago

Pull Request Here: https://github.com/WhoopInc/vagrant-s3auth/pull/5

waisbrot commented 9 years ago

Thanks!