WhoopInc / vagrant-s3auth

Vagrant plugin for private, versioned boxes on Amazon S3.
MIT License
108 stars 23 forks source link

corrected AWS_SECRET_KEY and AWS_ACCESS_KEY to standard names #6

Closed philbert closed 9 years ago

philbert commented 9 years ago

Other tools like the vagrant-aws plugin and the ec2-api-tools expect the environment variables containing the secret and access key to be called AWS_SECRET_KEY and AWS_ACCESS_KEY.

benesch commented 9 years ago

Hey, thanks for the contribution. Actually, as far as I can tell, AWS_ACCESS_KEY_ID is the standard, and the ec2-api-tools is the odd duck.

See, for example, the AWS Ruby SDK—which we're now using in 1.0. If you'd like to update this PR to look in both AWS_ACCESS_KEY_ID and AWS_ACCESS_KEY, I'm all for it!