search

WhyAsh5114 / MyFit

Workout tracker inspired by the RP Hypertrophy App
https://my-fit-whyash5114.vercel.app/
GNU Affero General Public License v3.0
26 stars 3 forks source link

Bug with rep progression #28

Open Testah2024 opened 3 months ago

Testah2024 commented 3 months ago

For some reason on my friend's version of this app, the recommended reps for Assisted Pull Up today is "109" reps, despite last week being 9 reps.

Any idea whats going on here, and how to fix it?

image image

Testah2024 commented 3 months ago

And for some reason, even though the volume change is increased incorrectly with 109 reps, the colour displays as red but they click on it and it shows a 390% increase - Not displaying as green.

image

WhyAsh5114 commented 3 months ago

could you just confirm the rep and load numbers by scrolling horizontally in the input area? I just need to make sure that it is exactly -21.5 for 109 reps

Testah2024 commented 3 months ago

could you just confirm the rep and load numbers by scrolling horizontally in the input area? I just need to make sure that it is exactly -21.5 for 109 reps

I can't now because they already finished that workout, but I recall it was -21.88 for 109 reps.

WhyAsh5114 commented 3 months ago

I've added the compare functionality in editing mode, could you ask them to go into that workout's edit page and click on compare? Once they do that, ask them to take a screenshot of that exercise (Assisted pull up).

Testah2024 commented 3 months ago

They said no compare function is displaying

image

WhyAsh5114 commented 3 months ago

That's odd, could you share this screen that pops up when u just view the workout, is there a reference workout? Just to be clear, I needed the compare function from the newer (the one where the bug occurred).

Screenshot_2024-04-11-16-20-57-37_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

Ankilli commented 1 week ago

same here IMG_20240703_083017

WhyAsh5114 commented 1 week ago

Aw man, it seems like a bug with BW exercises... It's really difficult to repro on my side, so I'd request you all to try to get through this one and wait a bit for v3.

I would've fixed it if it was something small but it's already a spaghetti function which somehow is able to create automatic progression, I don't want to break other things as there aren't any tests in place either.

Ankilli commented 1 day ago

Aw man, it seems like a bug with BW exercises... It's really difficult to repro on my side, so I'd request you all to try to get through this one and wait a bit for v3.

I would've fixed it if it was something small but it's already a spaghetti function which somehow is able to create automatic progression, I don't want to break other things as there aren't any tests in place either.

wait.. I chose weighted exercise instead of BW in the exercise settings. sometimes the problem sits in front of the phone haha

WhyAsh5114 commented 1 day ago

ahh, that's why this was happening, thanks a lot for finding out the cause @Ankilli. Others with a similar issue, please try to do the same (change exercise weight type to BW) to fix it.