WhyJustRun / Clubsite

Platform for orienteering club communities
http://www.whyjustrun.ca
6 stars 4 forks source link

Map detail page - Created and Last Modified dates #164

Closed sgnewson closed 9 years ago

sgnewson commented 9 years ago

From discussion with the FWOC users of Clubsite:

The Created and Last Modified date rows in the Statistics table of the map information page are confusing. They expected the dates to be the dates the map was created and updated, not the dates the file was uploaded or modified.

They have no use for the dates the file was uploaded or modified. So we are wondering if any of the other clubs use these values. If not we would like to remove them, or change them to show dates manually entered by the person uploading the map file.

Action item: 1) find out if any clubs would miss these lines if they were removed or changed.

Proposed changes: 1) either, remove these lines from the Statistics table 2) or, change these lines to show dates manually entered by the person uploading the map.

For simplicity I would propose only making these changes to all clubsites or none, instead of adding an administration option to pick between two systems.

russellporter commented 9 years ago

Hi Scott,

I think it is fine for to remove the existing dates from the UI for all clubs. I've heard similar complaints from other clubs so I am confident no one will miss them. Lets leave the data in the database though - it is pretty typical to have created/modified dates stored in CMS's anyways.

You could add new columns for user entered created and/or updated dates if you like. It's up to you.

Maybe make the first change (removing the dates from the UI) as a Github Pull Request to this repository, then I can review it (code reviews are a common practice in software companies that I would like to start doing for WhyJustRun too) and we can release it to production.

Then if you want to add the user entered dates, you can do that as a second change.

It's up to you anyways, I think your proposed changes are very reasonable. :)

Cheers, Russell

sgnewson commented 9 years ago

I have a commit that removes those two lines from the table in the Maps view. Can you give me commit access on the github repository to push them?

russellporter commented 9 years ago

Hey Scott,

Thanks so much for this! Can you submit the commit as a pull request? You don't need push rights to do that, and I would like to try to start reviewing code for WhyJustRun :)

On Mon, Feb 16, 2015 at 3:10 AM, Scott Newson notifications@github.com wrote:

I have a commit that removes those two lines from the table in the Maps view.

Can you give me commit access on the github repository to push them.

Reply to this email directly or view it on GitHub: https://github.com/WhyJustRun/Clubsite/issues/164#issuecomment-74445322

sgnewson commented 9 years ago

Ok, there should be a pending pull request now.

On Sun, Feb 15, 2015 at 10:11 PM, Russell Porter notifications@github.com wrote:

Hey Scott,

Thanks so much for this! Can you submit the commit as a pull request? You don't need push rights to do that, and I would like to try to start reviewing code for WhyJustRun :)

On Mon, Feb 16, 2015 at 3:10 AM, Scott Newson notifications@github.com wrote:

I have a commit that removes those two lines from the table in the Maps view.

Can you give me commit access on the github repository to push them.

Reply to this email directly or view it on GitHub: https://github.com/WhyJustRun/Clubsite/issues/164#issuecomment-74445322

— Reply to this email directly or view it on GitHub https://github.com/WhyJustRun/Clubsite/issues/164#issuecomment-74460713.

russellporter commented 9 years ago

Now to push your changes to the production website, just run the deploy_all.sh command (in the google doc) :)

On Mon, Feb 16, 2015 at 9:03 AM, Scott Newson notifications@github.com wrote:

Ok, there should be a pending pull request now. On Sun, Feb 15, 2015 at 10:11 PM, Russell Porter notifications@github.com wrote:

Hey Scott,

Thanks so much for this! Can you submit the commit as a pull request? You don't need push rights to do that, and I would like to try to start reviewing code for WhyJustRun :)

On Mon, Feb 16, 2015 at 3:10 AM, Scott Newson notifications@github.com wrote:

I have a commit that removes those two lines from the table in the Maps view.

Can you give me commit access on the github repository to push them.

Reply to this email directly or view it on GitHub: https://github.com/WhyJustRun/Clubsite/issues/164#issuecomment-74445322

— Reply to this email directly or view it on GitHub https://github.com/WhyJustRun/Clubsite/issues/164#issuecomment-74460713.


Reply to this email directly or view it on GitHub: https://github.com/WhyJustRun/Clubsite/issues/164#issuecomment-74463519

sgnewson commented 9 years ago

Done