WhyNotHugo / django-mercadopago

⚠️ Deprecated. Use https://github.com/jazzband/django-payments/ instead.
ISC License
33 stars 12 forks source link

comment removed from Preference model #10

Closed pwqw closed 5 years ago

pwqw commented 5 years ago

Preference mp_id is actually an UUID.

codecov[bot] commented 5 years ago

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   67.74%   67.74%           
=======================================
  Files          25       25           
  Lines         403      403           
  Branches       28       28           
=======================================
  Hits          273      273           
  Misses        127      127           
  Partials        3        3
Impacted Files Coverage Δ
django_mercadopago/models.py 46.91% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b00e7f3...bacfa8a. Read the comment docs.

WhyNotHugo commented 5 years ago

Nope. UUIDs are 32 characters (128bits). This is actual production data from a single system:

SELECT DISTINCT length(mp_id), count(mp_id) FROM mp_preference GROUP BY length(mp_id);
 length | count  
--------+--------
     12 |      3
     15 |      1
     16 |      1
     19 |    607
     24 |      1
     25 |      3
     29 |      7
     36 |   3118
     45 | 139130
     46 | 124330