Whysochong / pe

0 stars 0 forks source link

EditProj Exception thrown is too confusing #11

Open Whysochong opened 1 year ago

Whysochong commented 1 year ago

image.png

Not too sure why there is the mention of staff list when failing to provide index for editproj

nus-se-script commented 1 year ago

Team's Response

As mentioned in the user guide and the error message, the index must be a number between 1 and 2147483647. Since the index does not fall within this range, and index is a compulsory field, it is considered to be a command format error. Since it is a command format error, it will remind the user of the correct command format, and hence the additional information. An index error would be reserved for indexes that are within the valid range but not within the list size (e.g. list contains 10 items but index is 11 or more). Therefore, this behavior is expected and logical so we rejected this issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

e.g. error message does not match the error.

no point showing "Staff list for each ...." . Doesnt match error given or anything. This additional info should only be placed in user guide. Putting it in the error message will only confuse the users and they might not know what to do to correct their command. Moreover, they should already know that this command doesn't change the staff list through the user guide. So this sentence is redundant and should be removed to avoid confusion.


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: image.png

Please read the webpage for more info. Error thrown is grouped after Functionality flaw.