Whysochong / pe

0 stars 0 forks source link

Poor detection of duplicates #3

Open Whysochong opened 1 year ago

Whysochong commented 1 year ago

image.png
Adding additional whitespace will result in duplicate projects being added which shouldn't be the case.

nus-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

User can add 2 staff with the same name that differ by a space.

User can add 2 staff members 'John doe' and 'John doe' with similar names that differ by a space. It is possible that the user accidently adds an additional space which is not detected by the duplication detection. This input should be input as the two staff with similar names share every other field including phone number which is generally unique to a person.

image.png


[original: nus-cs2103-AY2223S1/pe-interim#3047] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We did make clear the limitations of our duplication detection in the user guide by stating that staff names and project names can consist of spaces that are considered characters.

image.png

image.png

According to the definition of bugs relating to duplicate detection on the CS2103T website, as long as we make clear the limitations, it cannot be considered a bug.

image.png

Hence we rejected this issue.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: image.png