WiIIiam278
commented
2 months ago We need to shade - but not relocate - the bukkit adventure adapter to support spigot (or else we're not allowed to list the plugin on SpigotMC.org). We simultaneously support Paper by using a paper plugin as an entry point and abstracting audience getter methods in the main plugin class. There is no scenario where this setup should break other plugins. Assuming CommandAPI targets paper, it should use native methods targeting paper; else shade the adapter itself. The adventure adapter shouldn't be relocated as this causes conflicts with paper's native unrelocated classes.
I suggest contacting the CommandAPI devs to enquire why this is rather than me. This isn't something I've heard reports of - and i certainly would have as I believe CommandAPI is popular - so make sure you're confident it's not a "you" problem first.
SzczurekYT
It seems that by shading the adventure api and legacy bukkit adapter HuskHomes "overwrites" the paper's adventure implementation for other plugins. This causes other plugins to use HuskHomes implementation instead of the native one. This obviously isn't good, and in my case this breaks another library I use for my plugins, which uses adventure under the hood. I'm not sure what's the proper fix here as it's kind of a complex situation, however it would be nice if HuskHomes didn't break my plugins 😄
Here is an example stacktrace of error that only happens with HuskHomes installed. Blacksmith is my plugin, and CommandAPI is - you guess it, a command library that dispatches the error causing code, which tries to open a gui, but fails when setting an item's name which invokes adventure.
Stacktrace
``` [14:52:09 ERROR]: [CommandAPI] Unhandled exception executing '/blacksmith' java.lang.ExceptionInInitializerError: null at Blacksmith-1.0.2.jar/yt.szczurek.blacksmith.BlacksmithCommand.lambda$register$1(BlacksmithCommand.java:31) ~[Blacksmith-1.0.2.jar:?] at CommandAPI-9.5.1-Mojang-Mapped.jar/dev.jorel.commandapi.executors.PlayerCommandExecutor.run(PlayerCommandExecutor.java:48) ~[CommandAPI-9.5.1-Mojang-Mapped.jar:?] at CommandAPI-9.5.1-Mojang-Mapped.jar/dev.jorel.commandapi.executors.NormalExecutor.executeWith(NormalExecutor.java:44) ~[CommandAPI-9.5.1-Mojang-Mapped.jar:?] at CommandAPI-9.5.1-Mojang-Mapped.jar/dev.jorel.commandapi.CommandAPIExecutor.execute(CommandAPIExecutor.java:137) ~[CommandAPI-9.5.1-Mojang-Mapped.jar:?] at CommandAPI-9.5.1-Mojang-Mapped.jar/dev.jorel.commandapi.CommandAPIExecutor.execute(CommandAPIExecutor.java:110) ~[CommandAPI-9.5.1-Mojang-Mapped.jar:?] at CommandAPI-9.5.1-Mojang-Mapped.jar/dev.jorel.commandapi.CommandAPIExecutor.execute(CommandAPIExecutor.java:91) ~[CommandAPI-9.5.1-Mojang-Mapped.jar:?] at CommandAPI-9.5.1-Mojang-Mapped.jar/dev.jorel.commandapi.CommandAPIHandler.lambda$generateCommand$0(CommandAPIHandler.java:261) ~[CommandAPI-9.5.1-Mojang-Mapped.jar:?] at com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.2.9.jar:?] at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:31) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:19) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.commands.execution.CommandQueueEntry.execute(CommandQueueEntry.java:5) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:103) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.commands.Commands.executeCommandInContext(Commands.java:448) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.commands.Commands.performCommand(Commands.java:355) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.commands.Commands.performCommand(Commands.java:342) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.commands.Commands.performCommand(Commands.java:337) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.server.network.ServerGamePacketListenerImpl.performUnsignedChatCommand(ServerGamePacketListenerImpl.java:2202) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$14(ServerGamePacketListenerImpl.java:2176) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:151) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1511) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:195) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:125) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1488) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1411) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:135) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1377) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1238) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:323) ~[paper-1.20.6.jar:1.20.6-148-20f5165] at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?] Caused by: java.lang.UnsupportedOperationException at HuskHomes-Paper-4.7.1-a90ff0a-indev.jar/net.kyori.adventure.platform.bukkit.MinecraftComponentSerializer.