search

WiIIiam278 / HuskSync

A modern, cross-server player data synchronisation system
https://william278.net/project/husksync
Apache License 2.0
160 stars 128 forks source link

Add support for Redis Sentinels #216

Closed romanalexander closed 8 months ago

romanalexander commented 8 months ago

Interesting, fair enough - happy to add this sort of thing if users are using it. Thanks for your work!

One small request that'd also be neat for this PR: A config option to change the database number (currently is hardcoded to 0)

Redis PubSub doesn't respect database numbers, so the channels would need to be changed to separate them out to not have strange cross-contamination issues. This could break existing plugins if they subscribe directly to the topics for behavior.

Also additionally some Redis topologies don't support database numbers which could cause confusion.

WiIIiam278 commented 8 months ago

Interesting, understood - best left as is then :)