WiIIiam278 / HuskSync

A modern, cross-server player data synchronisation system
https://william278.net/project/husksync
Apache License 2.0
160 stars 128 forks source link

If potion effect syncing is off while attribute syncing is on, discrepancies occur #349

Closed Kryniowesegryderiusz closed 1 month ago

Kryniowesegryderiusz commented 1 month ago

I believe I've found bug for obtaining permanent minecraft effects if they modify attributes.

If I've attributes and potion_effects sync enabled and give myself effect that modify attributes then after switching servers attributes are beeing synced, but effects arent, so they are never beeing removed from player.

Example: Give yourself a Haste/Strength/Mining Fatigue etc. effect, then switch server. Attributes would never be taken off from the player, because potion effect is not beeing synced therefore there is nothing that would remove attribute. image

Info: image image image I've disabled attributes syncing after spoting this issue

WiIIiam278 commented 1 month ago

Interesting. Currently Attribute syncing must be on to use potion effect syncing but not the other way. Should prob have a look at this.