search

WiIIiam278 / PAPIProxyBridge

A bridge library plugin for using PlaceholderAPI on proxy servers
https://william278.net/project/papiproxybridge
Apache License 2.0
37 stars 11 forks source link

`findServers()` returns the wrong type #125

Closed Andre601 closed 5 months ago

Andre601 commented 5 months ago

Through a bug report did I find out, that findServers() now returns a set instead of a List. Why was this breaking(!) change made? And why was there no mention in the updates?

Andre601 commented 5 months ago

This is especially bad give that it was a patch version update, while this is in fact a breaking change, going against proper semantic versioning (Assuming your API follows that).

WiIIiam278 commented 5 months ago

Hi there, @alexdev03 made this change and it looks like I didn't notice during the review.

That's on me for not noticing that a breaking change was made. It should be rolled back and I consider this a bug; i'll revert that functionality & push out an update.

alexdev03 commented 5 months ago

Hi, sorry for the inconvenience, this change has been made to fix an exception that your plugin was throwing. https://github.com/WiIIiam278/PAPIProxyBridge/issues/97. At the moment of fixing that problem I didn't think about it.

Andre601 commented 5 months ago

Understandable.

I implemented a fix on my end that should make it work with both the old and new return type.

WiIIiam278 commented 5 months ago

@Andre601 We've pushed an update out now to resolve this. We recommend switching to the new method which resolves the issue Alex mentioned above (but we've left the old method in as deprecated to avoid the aforementioned breakage).

Apologies for this, thanks for your work maintaining PAPI :)