search

WiIIiam278 / PAPIProxyBridge

A bridge library plugin for using PlaceholderAPI on proxy servers
https://william278.net/project/papiproxybridge
Apache License 2.0
37 stars 11 forks source link

feat: add component methods for fetching gson components #67

Closed Jarva closed 1 year ago

WiIIiam278 commented 1 year ago

I guess my only slight question mark I raise to you is: wouldn't it be nice to provide a method to let users pass components directly? I imagine this would be pretty handy, though I could of course be wrong. Shouldn't be too hard, right? Just deserializing the components before handling them :)

That aside. This looks fantastic, great work.

Jarva commented 1 year ago

I'm not sure what you mean by letting the user pass components directly, could you show me a pseudo example?

WiIIiam278 commented 1 year ago

Needs rebasing on #71 to add the new check for both channels

WiIIiam278 commented 1 year ago

I'm not sure what you mean by letting the user pass components directly, could you show me a pseudo example?

Nevermind this, I forgot how MiniPlaceholders works.

WiIIiam278 commented 1 year ago

@Jarva Do you have any more plans for this -- or is this good to merge? Still want to run a few more tests as I did merge some velocity-side changes, but I don't have any more complaints after my initial review really :)