search

WiIIiam278 / PAPIProxyBridge

A bridge library plugin for using PlaceholderAPI on proxy servers
https://william278.net/project/papiproxybridge
Apache License 2.0
37 stars 11 forks source link

Support MC 1.20.2 for Fabric #86

Closed BluSpring closed 9 months ago

BluSpring commented 11 months ago

hold on, don't merge yet, need to fix some things

WiIIiam278 commented 11 months ago

All good, I was planning on testing first anyway.

BluSpring commented 11 months ago

Okay, so I'm currently running into a problem here where the client seems to run into an EOFException when it receives the packet, and I just cannot figure out why that is the case.

WiIIiam278 commented 11 months ago

Don't you have to read the identifier bytes first? I had to make a change like this for HH

BluSpring commented 11 months ago

With this one, I don't think so? That would have to be done if I did packet.write instead of packet.payload().write, so that shouldn't have to be the case.

WiIIiam278 commented 11 months ago

Oh interesting. Sounds like I over complicated my HH code

WiIIiam278 commented 9 months ago

Superseeded by #95 - we ended up removing the mixin and registering a packet handler.