search

WickedShell / echelon

http://echelon.bigbrotherbot.net
14 stars 7 forks source link

GUID Length #20

Closed FrikFry closed 13 years ago

FrikFry commented 13 years ago

A minor issue, but one none the less. Echelon gives a small error message on the clientdetail pages when the GUID length is less than 32 characters long. This poses a small issue on Call of Duty Black Ops when GUIDs are usually 8 characters long.

WickedShell commented 13 years ago

Eh? I knew about the half length GUID being actually 8 characters, but not about COD having GUIDs of 8 characters....

I guess I will be writing stuff for the supproted games array after all... :)

FrikFry commented 13 years ago

Well, cod black ops guids are variable in length. I think the min is 6 or 7 and then it varies up to something like 10.

EDIT: Might be just as easy to remove the length check.

WickedShell commented 13 years ago

I think this may be an instance to finally respect the supported games array?

The fact that it checks against the length of 32 leads me to believe erie.32 was an UrT or SmG player.. :)

FrikFry commented 13 years ago

Well, I don't know if he ever played those games, but I knew of him through my clan called EdgeGamers. That's why the default clan tags we're EdgeGamers tags.

WickedShell commented 13 years ago

Yeah I noticed that. Providing default tags was also a bit problematic as if you cleared them it broke the stuff that used them :) This actually (empty tags) has been fixed.

Are there a set of rules that determine valid GUID's for COD? (Ie must be a hex sequence, or between this length etc?)

FrikFry commented 13 years ago

I believe the guid lengths for all the cods except 6 and 7 are suppose to be 32 characters long. I don't know about CoD6, but I do know that CoD7 is suppose to be 6 or longer.

I'm not aware of any expected sequences or anything like that. AFAIK, its just a length thing.

WickedShell commented 13 years ago

Hm, okay. I know all the quake3 based ones for example it's supposed to be 32 characters long, and be made of numbers and the letters A-F, and if it's not it indicates a strong possibility of hacking. (There are some well documented aimbots etc that use custom GUID's that have illegal characters), which is why there is the GUID check code.

I'll see if I can pull a list and then tie them in together, so that GUID length messages reflect gametype

WickedShell commented 13 years ago

I forgot to mention it, but this got quitely fixed I believe, with regards to correct length checking. (I only had UrT databases to test on, so I'm not sure if it's correct for other games) Barring a typo I believe this is correct, and am closing it, unless told otherwise.