search

WickedShell / echelon

http://echelon.bigbrotherbot.net
14 stars 7 forks source link

Search on Alias #25

Closed 82ndab-Bravo17 closed 13 years ago

82ndab-Bravo17 commented 13 years ago

I haven't been able to find a way to search on someones alias.

WickedShell commented 13 years ago

Is there a reason to differentiate between searching for alias's and the current name when searching?

82ndab-Bravo17 commented 13 years ago

Yes, it is often useful to be able to know what a players current name is, and also to be able to tell if they have changed it from the one that you are looking for.

It's also good because of the 'phantom' aliases that crop up when a player joins a slot that another player has just left, it makes it easier to find the real player with that name.

WickedShell commented 13 years ago

fixed in commit 26553d75955e93837420

Searching by alias now works, but its not included in the "all" button as it makes the query really really slow, and returns a lot of bad results. Any suggestions for what to rename this button?

82ndab-Bravo17 commented 13 years ago

For some reason the alias display when you click on a person that has the alias doesn't show all the aliases for that person, sometimes not even the one that was searched on, which was what alerted me to the problem.

The sql picks them all up, but they are not displayed.

It would also be good to show the actual alias found as well as the name in the initial display, to help narrow down the search. (eg 'eric' picks up eric, maverick, frederick etc and at the moment there is no way on the first screen to find out which was matched.

WickedShell commented 13 years ago

Oops. So I thought you had only meant the search page orgianlly. So I put together a new query for it, but I didn't look at the exsisting query at all to do so (which is fine as they aren't that related). But the side effect of this is I missed the error in the alias table. It was not showing aliases where time added = time edited, which means all single connect aliases were hidden. The logic behind that was probably to not show the current name as an alias, but it hid stuff that as you point out, we want to view.

That was an excellent point for showing what was matched. It's a new column as of commit 7504dd5d9ac262e00838

I believe this all fixed now. If not reopen it and kick me :)