search

WickedShell / echelon

http://echelon.bigbrotherbot.net
14 stars 7 forks source link

fix issue #34 #35

Closed thomasleveil closed 13 years ago

thomasleveil commented 13 years ago

Signed-off-by: Courgette courgette@bigbrotherbot.net

WickedShell commented 13 years ago

The htmlentities call around the sendback/display makes sens to me, but I'm not sure about doing it to the email message's content. What happens if it gets sent to a mail client that doesn't do html? Wouldn't it then look like;

$OXEn4Jom9

Although the flipside is if you're mail client that does do html characters, this is still an issue...

What if I pulled all the "special" characters from the password generator, stuck in numbers instead, and kept the htmlentites around the no mail mode option?

thomasleveil commented 13 years ago

generating a password with only "classic" chars would of course make things easier.

regarding emails and HTML, while using email clients no supporting html is very rare by now, in the past an email with html content would also have a text content. The html content was 'attached' to the email through Multi-Part MIME data.

See http://en.wikipedia.org/wiki/HTML_e-mail#Multi-part_formats and here an example in PHP : http://www.webcheatsheet.com/PHP/send_email_text_html_attachment.php

WickedShell commented 13 years ago

I think we'll switch to "classic" as you put it regardless, but switch to this as well.

WickedShell commented 13 years ago

i appear to be dumb but how do I pull this? (never been on this end of a project before :/ )

thomasleveil commented 13 years ago

well never did I. But the github help section describes the process : http://help.github.com/pull-requests/#managing_pull_requests

WickedShell commented 13 years ago

I'd been trying to follow that actually, but I had been doing it from one folder to high.... whistles got it now :)