search

WickedShell / echelon

http://echelon.bigbrotherbot.net
14 stars 7 forks source link

unban logging #39

Closed FrikFry closed 13 years ago

FrikFry commented 13 years ago

Currently the client id of the person who's being unbanned isn't recorded in the log. You need to change the unban.php so that it gets the cid with post and checks it for emptyinput so that it is able to pass it into the log.

get vars

$ban_id = $_POST['banid']; $type = cleanvar($_POST['type']); $cid = $_POST['cid'];

check that the sent form token is correct

if(verifyFormToken('unban'.$ban_id, $tokens) == false) // verify token ifTokenBad('Unban');

Check for empties

emptyInput($type, 'type not sent'); emptyInput($ban_id, 'ban id not sent'); emptyInput($cid, 'cid not sent');

WickedShell commented 13 years ago

Fixed. The only caveat with the above is that it was missing to cleanvar's (used to prevent injections) and a validatiation that cid was infact numeric, and one of those missing was already in the code. But that was a simple change. (I also finly fixed the stupid / bug that occured when banning people around the reason.

Thanks!