WickedShell / echelon

http://echelon.bigbrotherbot.net
14 stars 7 forks source link

Password reset #43

Closed FrikFry closed 12 years ago

FrikFry commented 13 years ago

The previous thing you mentioned worked, but the error message needs to be updated because the policy link it gives is no longer functioning. I replaced it with:

if(!$this->pwStrength($password, $min_pw_len)) { // false: not strong enough
    return 'The password you supplied is not strong enough, a password must be longer than '. $min_pw_len .' characters and should contain a mix of numbers, uppercase characters, and lowercase characters.';
    exit;
}
WickedShell commented 13 years ago

Agreed on the policy file, I switched it to what you had. With regards to the exit though... A number of places in echelon do this, and I have been systematically wipeing them out, unless some can tell me why that's a bad idea. As far as I read the code, the return call, ensures you will never reach the exit; you have there, so why call it?