Wicklets / wick-editor-2018

Archived - New repo is now at github.com/wicklets/wick-editor
GNU General Public License v3.0
515 stars 57 forks source link

Wick "fakes" bold typefaces instead of retrieving actual bold font from Google Fonts #768

Open kryptot7 opened 6 years ago

kryptot7 commented 6 years ago

Example: Actual Ubuntu Bold font image

What Wick displays when you choose Ubuntu font and press the Bold button: image

Wick seems to put an outline around the regular variation of the font instead of retrieving "Ubuntu Bold" from Google Fonts.

Luxapodular commented 6 years ago

Hmm, @zrispo Thoughts on this?

Luxapodular commented 6 years ago

Consider @kryptot7's suggestion in #668 for potential Inspector UI improvements for this as well.

zachrispoli commented 6 years ago

Whoops looks like the font loading system is only loading the normal font weight, so I guess the browser is faking bold fonts automatically - interesting!

After looking at the list of google fonts, it looks like some fonts have several weights, and some only have one! Not sure how to handle this in the GUI, any thoughts?

kryptot7 commented 6 years ago

One approach could be similar to what Google Docs does. In Google Docs, most typefaces seem to switch between Normal (400) and Bold (700) variants when you press the Bold button. However, you can choose other weights as well. image I played around with this menu and recorded its behavior. adae084d-441b-4472-b7f0-1a37c8aeae13

(In the part where I select Thin, the same thing happens when I select Medium)

As for the actual UI element, you could have a drop down menu like the one that already exists for selecting the typeface. It requires fewer clicks than Google Docs' way of selecting font weights.