search

Widdershin / cycle-restart

Swap out the code in your Cycle.js apps on the fly!
MIT License
123 stars 11 forks source link

Cannot set property 'isDisposed ' of undefined #35

Closed alkhe closed 8 years ago

alkhe commented 8 years ago

This error causes webpack to ditch the reload:

http://i.imgur.com/A43npmO.png

This happens inside of a certain function that was given to onDispose in restartable, which traces the error either to https://github.com/Widdershin/cycle-restart/blob/master/src/restartable.js#L154 or https://github.com/Widdershin/cycle-restart/blob/master/src/restartable.js#L98.

repro: https://github.com/edge/cyc/tree/restart

Widdershin commented 8 years ago

I've released v0.0.10 to address this issue.

I've tested that it works with cyc, that was a very helpful repro case.

I made a pull request to upgrade cycle-restart. https://github.com/edge/cyc/pull/7

Could you please give it a go and let me know if that fixes it for you?

alkhe commented 8 years ago

Got it to work.

Widdershin commented 8 years ago

Awesome! I think cyc is the easiest way to get started with hot reloading at the moment. We should add some info to the readme about that.

alkhe commented 8 years ago

cc @staltz :)

staltz commented 8 years ago

@edge can you submit a PR to cyclejs.github.io in the Getting Started page to add a reference to cyc?