search

Widdershin / cycle-restart

Swap out the code in your Cycle.js apps on the fly!
MIT License
123 stars 11 forks source link

Support symbol properties on wrapped streams #68

Closed xtianjohns closed 6 years ago

xtianjohns commented 6 years ago

Ensure properties that are symbols are included in streams wrapped by cycle-restart.

Many stream libraries are using symbols to standardize interoperability between one another. When transforming streams as part of cycle-restart, it is important to retain all behavior that is present on the stream or on its prototype.

This change includes a shim for Object.getOwnPropertySymbols, which is used to retrieve all symbols from an object.

Resolves #67.

Widdershin commented 6 years ago

Looks great! Simple and pragmatic change, easy to review and test 😄

Thanks for writing automated tests as well, that's awesome.

Widdershin commented 6 years ago

Released in v0.2.3 😄.

I've also invited you to be a project collaborator. This means that you can work on branches in this repository instead of forks, which means we can collaborate more effectively. I also welcome you to triage incoming issues, review pull requests and propose new features/changes to the codebase.

This does not in any way obligate you to contribute, but any contributions are greatly appreciated.

Thanks again!