search

Widdershin / tricycle

Try Cycle.js in your browser, no setup required.
http://widdersh.in/tricycle/
MIT License
26 stars 4 forks source link

enable draggable window resizing #16

Closed griffinmichl closed 8 years ago

griffinmichl commented 8 years ago

Still learning cycle. Would greatly appreciate any feedback!

I look forward to contributing more in the near future.

RE: #9

Widdershin commented 8 years ago

Wow, good on you for tackling this one. I'm out of town for the next day so I'll review this PR after that :)

Widdershin commented 8 years ago

Hi @gm758. I've left you some feedback. Please let me know if you need any clarification or have any other questions.

Once you've had a crack at those we can test and merge this puppy :smile:

griffinmichl commented 8 years ago

This feedback is excellent. Thanks so much. I should have changes in a couple minutes.

Speaking of tests, would you be open to a PR adding tests to this project?

Widdershin commented 8 years ago

Definitely, I would love that. I think some refactoring would be needed but I'm happy to assist in any way. On 16/04/2016 2:41 PM, "Griffin Michl" notifications@github.com wrote:

This feedback is excellent. Thanks so much. I should have changes in a couple minutes.

Speaking of tests, would you be open to a PR adding tests to this project?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/Widdershin/tricycle/pull/16#issuecomment-210721627

griffinmichl commented 8 years ago

@Widdershin Feedback has been incorporated

Widdershin commented 8 years ago

Nicely done :smile:

I'm off to catch a plane in a few hours, and will be travelling for the next 24 hours or so, so I won't be able to test and merge your pull request for a few more days. Hope that's okay.

griffinmichl commented 8 years ago

No rush. I'm starting to experiment with different ways to let users save their work via gists. I could see a bit of refactoring being helpful for continued development.

griffinmichl commented 8 years ago

Strange. I'm not sure what was going on with that bug, but I've added select(':root') and everything appears to be working

Widdershin commented 8 years ago

Sorry for the delay in getting this merged @gm758! This is really great work, and is a really nice usability addition to tricycle.

I'll merge and deploy now 😄

Widdershin commented 8 years ago

And deployed! http://widdersh.in/tricycle/

Works just dandy! Thanks again for your contribution 👍