search

WideChat / Rocket.Chat.Android

Rocket.Chat Native Android Application
https://rocket.chat
MIT License
12 stars 6 forks source link

RN: adding follow button to user info #364

Open bizzbyster opened 5 years ago

Kailash0311 commented 5 years ago

How should a Pull Request be made based on the Prototype? (I have never made a PR on a prototype, please guide me.) (What all should Prototype contain?)

Kailash0311 commented 5 years ago

Update on the follow button.

follow_button_video Sorry for the low resolution. (Warning statements are generated by me as a way to see the state of the UI.) I will change the place of the followers and following to be more like this

rn

Comments are welcome.

Kailash0311 commented 5 years ago

Current version:

Screenshot_2019-05-31-20-14-33-840_chat rocket reactnative

Comments are welcome.

Next step: Make followers/following button tappable so that it opens the list of the followers/following respectively.

bizzbyster commented 5 years ago

the update of following/followers count should show up in the gif

bizzbyster commented 5 years ago

Include the UI test in this PR.

Kailash0311 commented 5 years ago

followButtonPreview

This is the present version. (Comments:

  1. I click on the followers button and then the followers screen comes, i don't know why that tap wasn't visible,
  2. The loading time of followers is more because I am calling an api which fetches members of the 'GENERAL' room.
  3. Exact similar screen appears on tapping the following number except for the heading.
  4. I have used many components from the view which shows members of a room/channel with slight modifications here and there and because of that the functionality of search, clicking on a user to dm and etc, remains intact. )
ear-dev commented 5 years ago

Include the UI test in this PR.

For reference, Govind's PR with the first UI tests is here: https://github.com/GOVINDDIXIT/Rocket.Chat.Android/pull/9 This PR also includes unit tests, but you will find the UI tests under the app/src/androidTest path.

Kailash0311 commented 5 years ago

Covered in Kailash0311/Rocket.Chat.ReactNative#2