[FIX] Camera crash on ChatRoomFragment

WideChat / Rocket.Chat.Android

Rocket.Chat Native Android Application

https://rocket.chat

MIT License

12 stars 6 forks source link

[FIX] Camera crash on ChatRoomFragment #476

Closed Shailesh351 closed 5 years ago

Shailesh351 commented 5 years ago

Closes #339

Changes

Fix Crash on ChatRoomFragment
Add run time permission for Camera and storage
Add translations for permission denied msg

ear-dev commented 5 years ago

@Shailesh351 There is also a "take photo" option in the profile fragment. Can you add the permissions dialog there as well please... thanks.

ear-dev commented 5 years ago

This looks good Shailesh..... thanks! I'll merge this.

FYI - can you please pull our veranda branch into your fork before making new PRs, to get up to date. Your checksum hash for the gradle distribution is incorrect, and we have fixed it in our fork. That is why your builds are not passing in CircleCI....