search

WideChat / Rocket.Chat.Android

Rocket.Chat Native Android Application
https://rocket.chat
MIT License
12 stars 6 forks source link

log sendMessage exception to google analytics #534

Closed bizzbyster closed 5 years ago

bizzbyster commented 5 years ago
  1. fix problem where the message sent analytics point was not covering all cases of sent messages.
  2. add description of the exception that caused sendMessage to fail.
bizzbyster commented 5 years ago

Its just a string

On Wed, Jul 24, 2019 at 12:49 PM mr_kite notifications@github.com wrote:

@jaytat0 commented on this pull request.

In app/src/main/java/chat/rocket/android/chatroom/presentation/ChatRoomPresenter.kt https://github.com/WideChat/Rocket.Chat.Android/pull/534#discussion_r306915024 :

@@ -1166,16 +1169,6 @@ class ChatRoomPresenter @Inject constructor( } }

  • private fun logMessageSent() {
  • when {
  • roomTypeOf(chatRoomType) is RoomType.DirectMessage ->
  • analyticsManager.logMessageSent(SubscriptionTypeEvent.DirectMessage)
  • roomTypeOf(chatRoomType) is RoomType.Channel ->
  • analyticsManager.logMessageSent(SubscriptionTypeEvent.Channel)
  • else -> analyticsManager.logMessageSent(SubscriptionTypeEvent.Group)
  • }
  • }

currently Subscription Type is something that's tracked in firebase and seems like something we would want in the future. Am I right in saying we would no longer be tracking that? or am I misunderstanding how that will work with message_type?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/WideChat/Rocket.Chat.Android/pull/534?email_source=notifications&email_token=AA6RAAH4OQCOTTZ2D5DVL33QBCB3JA5CNFSM4IFTZXO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7OSQNQ#pullrequestreview-266151990, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6RAAG2UG2G4YIYQ3UYNB3QBCB3JANCNFSM4IFTZXOQ .