Widen / cloudfront-auth

An AWS CloudFront Lambda@Edge function to authenticate requests using Google Apps, Microsoft, Auth0, OKTA, and GitHub login
ISC License
623 stars 148 forks source link

Update Lambda version to NodeJS 12 #55

Closed blurrah closed 4 years ago

blurrah commented 4 years ago

AWS Lambda is dropping NodeJS 8 support on December 31st, as seen here.

This PR updates it to the latest LTS version.

payton commented 4 years ago

Thank you!

z0rc commented 4 years ago

This is actually incorrect. Lambda@Edge doesn't support nodejs12.x runtime, at least at the moment this comment is written. See https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/lambda-requirements-limits.html#lambda-requirements-lambda-function-configuration

Runtime should be downgraded to nodejs10.x.

payton commented 4 years ago

Thanks @z0rc . Reverted the PR - on mobile but will take a look when I get back.

acaire commented 4 years ago

Node.js 12.x Now supported as of March - https://aws.amazon.com/about-aws/whats-new/2020/03/lambda-at-edge-node12-python38/