WidgetOptions / widget-options

Additional Widget options for better widget control. Available on
https://widget-options.com/
GNU General Public License v3.0
34 stars 16 forks source link

jQuery UI css conflicts #6

Closed twiginteractive closed 7 years ago

twiginteractive commented 8 years ago

Hi -

It looks like the JQUI CSS enqueued by the plugin is conflicting with some other plugins, so that buttons and other elements in the WP Admin area are affected. Would it be possible to add an option in the plugin settings to make enqueuing this UI theme optional?

Thanks

phpbits commented 8 years ago

Hi @twiginteractive,

Thank you very much for reporting this issue, can you please let me know which is the other plugin and will be very happy to further check and fix the issue. You can use :

wp_dequeue_style( 'widgetopts-jquery-ui' );

for the meantime to remove widget option's jquery ui. Let me know how it goes. Thanks!

Cheers, Jeffrey

twiginteractive commented 8 years ago

Hi @phpbits

Thanks for the quick response and the dequeue tip.

I noticed the conflict with the Types plugins (https://wp-types.com/) - nothing terrible, just some buttons and UI elements that were being overridden by Widget Options.

Cheers! Jonathan

phpbits commented 8 years ago

Hi @twiginteractive

Thank you very much! Will let you know when the fix was uploaded.

Cheers, Jeffrey

phpbits commented 7 years ago

@twiginteractive

Can you send me screenshot of the conflicts? I've installed : https://wordpress.org/plugins/types/ and didn't see any issues. Thanks!

Cheers, Jeffrey

twiginteractive commented 7 years ago

snag_program-0170 snag_program-0171

@phpbits

Actually it was the Views plugin part of the Toolset suite that had conflicts - when you edit or delete a View, the attached screenshots show the popups style conflicts.

Maybe Widget Options could conditionally enqueue the UI CSS only for pages controlled by WO and not other plugins?

Thanks!

phpbits commented 7 years ago

@twiginteractive

I don't have the full Toolset Plugin. Please create a support ticket here : http://widget-options.com/contact/ and include a link where I can download a copy. Will just use it for this testing purposes.

Also, I've added some jQuery UI fixes for DIVI on the latest Widget Options version, please let me know if you are using the latest version and still having this issue. Thanks!

Cheers, Jeffrey

twiginteractive commented 7 years ago

@phpbits

Hi - I've tested with latest WO and latest Toolset on a clean install - the CSS conflicts are still present (easiest test is just to go to Views -> New View. You can see the close icon and other stuff has been overridden)

I've put in a ticket with a link to dropbox for the Toolset components for you to use for debugging only - please delete when done.

Thanks!

phpbits commented 7 years ago

Hi @twiginteractive

Can you please replace your file with the develop branch files : https://github.com/phpbits/widget-options/tree/develop and check if the issue was fixed and if the plugin works perfectly. Thank you very much!

Cheers, Jeffrey

twiginteractive commented 7 years ago

Hey @phpbits -

I've replaced the plugin files with the dev branch, and the conflicts seem to be resolved for Views.

Thanks!

phpbits commented 7 years ago

Hi @twiginteractive

Sounds perfect :) Have you checked the widgets area and settings too; if working perfectly on your end too just like mine. Just like saving and front-end values. Again, thank you so much for the effort on making this plugin better and better.

Cheers!

twiginteractive commented 7 years ago

I checked a few options to test (hiding a widget on a certain page etc.) and everything seemed to work as expected!

phpbits commented 7 years ago

@twiginteractive

Sounds perfect! Will let my other testers finished checking all plugin features and will upload the changes. Thanks again!

Cheers!

phpbits commented 7 years ago

@twiginteractive

Fixes are now uploaded :) Feel free to update your copy. Thank you very much again!

Cheers, Jeffrey