HP drain isn't 100% accurate

Wieku / danser-go

Dancing visualizer of osu! standard maps and custom osu! client written in Go. Also a generator for osu! videos.

Other

753 stars 103 forks source link

HP drain isn't 100% accurate #288

Closed imsuck closed 1 year ago

imsuck commented 2 years ago

Describe the bug Danser thought I failed in the replay but when I use osu! to view the replay it's a pass.

Files replay output

Logs danser.log

Computer configuration: Operating System: EndeavourOS x86_64 (kernel: 5.19.12-arch1-1) CPU: Intel(R) Core(TM) i5-4210U GPU: Mesa Intel(R) HD Graphics 4400 (HSW GT2) Sound Card: I'm not sure

Wieku commented 2 years ago

I don't think I can fix that one. After analyzing replay data it should be a fail, even in osu.

If we look at this screenshot:

in osu, actually you get hit50:

But for some reason osu! decides to change it to hit300 because that bar disappears almost instantly.

Wieku commented 1 year ago

Left was an osu! replay bug that seems to be fixed in newest cuttingedge, but it turned out issue also lies on danser's side.

Wieku commented 1 year ago

It's not yet pushed to dev branch but it appears to be fixed:

https://user-images.githubusercontent.com/5307179/197432928-4c97b3e1-5796-4bc9-83da-4f3597fa539c.mp4