WietseWind / docker-rippled

Run XRP Ledger (rippled) node in a Docker container
https://hub.docker.com/r/xrpllabsofficial/xrpld
MIT License
60 stars 34 forks source link

The changes to `entrypoint.sh` are not reflected in the 1.11.0 image #20

Closed ckniffen closed 1 year ago

ckniffen commented 1 year ago

This commit is not reflected in the latest image. 8315fc15710311b11bb8df56cc8eb92baf3ad9dc

This is the contents of entrypoint.sh in latest and 1.11.0 images

#!/bin/bash

rippledconfig=`/bin/cat /config/rippled.cfg 2>/dev/null | wc -l`
validatorstxt=`/bin/cat /config/validators.txt 2>/dev/null | wc -l`

mkdir -p /config

if [[ "$rippledconfig" -gt "0" && "$validatorstxt" -gt "0" ]]; then

    echo "Existing rippled config at host /config/, using them."

    /bin/cat /config/rippled.cfg > /etc/opt/ripple/rippled.cfg
    /bin/cat /config/validators.txt > /etc/opt/ripple/validators.txt

fi

# Start rippled, Passthrough other arguments
exec /opt/ripple/bin/rippled --conf /etc/opt/ripple/rippled.cfg "$@"

It should be:

#!/bin/bash

echo "Args:"
echo "    >> [$@]"
echo ""
echo "Env Args:"
echo "    >> [$ENV_ARGS]"
echo ""
echo "Env:"
printenv
echo ""

rippledconfig=`/bin/cat /config/rippled.cfg 2>/dev/null | wc -l`
validatorstxt=`/bin/cat /config/validators.txt 2>/dev/null | wc -l`

mkdir -p /config

if [[ "$rippledconfig" -gt "0" ]]; then
    echo "Existing rippled config at host /config/, using."
    /bin/cat /config/rippled.cfg > /etc/opt/ripple/rippled.cfg
fi

if [[ "$validatorstxt" -gt "0" ]]; then
    echo "Existing validator config at host /config/, using."
    /bin/cat /config/validators.txt > /etc/opt/ripple/validators.txt
fi

# Start rippled, Passthrough other arguments
exec /opt/ripple/bin/rippled --conf /etc/opt/ripple/rippled.cfg $@$ENV_ARGS
WietseWind commented 1 year ago

Oops 😱

So the build server didn't have the most recent version checked out. Will investigate how that happened.

For now I manually checked out, rebuilt & tagged.

Fixed for now! Thanks for the heads up!