Aufofill with `signAndSubmit`

[tequdev]

Fixed to do autofill in the signAndSubmit method as in xrpl.js.

[WietseWind]

Thank you!

I don't think this should be executed by default, always. This is a decision:

• Either the developer should make explicitly, buy adding the values, like here: https://github.com/WietseWind/xrpl-accountlib/blob/master/samples/sign-and-submit.mjs#L29
• Or the developer should explicitly opt in to filling all params by passing it to a dedicated method

sign and submit means exactly this: Sign and Submit what has been passed. By adding auto network & account property filling to the method, the method doesn't do what it the name suggests, it does more.

Another problem is that this is a breaking change (this lib is all over the place).

The way I feel this should be implemented is a separate (new) method, that wraps around signAndSubmit, adding the network values first so the developer passed colliding properties prevail.

E.g.:

prefilledSignAndSubmit(...)

Where this would basically do this (pseudocode):

const prefilledSignAndSubmit = async (
  transaction: Object,
  client: XrplClient | string,
  account: Account | Account[]
) => {
  rerturn signAndSubmit({
     // First the vals, so these are always defined
    ...(await utils.txNetworkAndAccountValues(client, transaction?.Account)).txValues,
    // Then the passed tx, so duplicate props overrule as tx comes last
    ...transaction,
  })
}

[tequdev]

I created this PR because Fee was eligible for autofill.

Of course I respect your decision.

I'll create another PR for prefilledSignAndSubmit👍